For SEO, not too short, not too long, the answer is somewhere between. It is good to have some keywords in the URL, but not too many.
For visitors, I don't think they mind if the URL is short or long. If they believe that there is something interesting to read, they will click it regardless of the length.